[ https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520892#comment-14520892 ]
Chris Nauroth commented on HIVE-9736: ------------------------------------- I have one remaining comment in Review Board suggesting a possible reusable {{combine}} method for combining {{FsAction}} values instead of duplicating the logic. Aside from that very minor thing, I'm basically +1 (non-binding) for the patch. However, I still couldn't get the consolidated v5 patch to apply to master, so I couldn't check a build with {{-Phadoop-1}}. > StorageBasedAuthProvider should batch namenode-calls where possible. > -------------------------------------------------------------------- > > Key: HIVE-9736 > URL: https://issues.apache.org/jira/browse/HIVE-9736 > Project: Hive > Issue Type: Bug > Components: Metastore, Security > Reporter: Mithun Radhakrishnan > Assignee: Mithun Radhakrishnan > Attachments: HIVE-9736.1.patch, HIVE-9736.2.patch, HIVE-9736.3.patch, > HIVE-9736.4.patch, HIVE-9736.5.patch > > > Consider a table partitioned by 2 keys (dt, region). Say a dt partition could > have 10000 associated regions. Consider that the user does: > {code:sql} > ALTER TABLE my_table DROP PARTITION (dt='20150101'); > {code} > As things stand now, {{StorageBasedAuthProvider}} will make individual > {{DistributedFileSystem.listStatus()}} calls for each partition-directory, > and authorize each one separately. It'd be faster to batch the calls, and > examine multiple FileStatus objects at once. -- This message was sent by Atlassian JIRA (v6.3.4#6332)