NihalJain commented on PR #8703: URL: https://github.com/apache/hbase/pull/8703#issuecomment-5838430231
I checkout out this PR and ran few tests via https://gist.github.com/NihalJain/0d5f0370598b7e730b0106ab8f3f0d0b this change LGTM! ``` @NihalJain ➜ /workspaces/hbase (HBASE-30419) $ ./validate-hbase-8703.sh ==== Repository and prerequisite checks ==== PASS: bin/hbase is executable PASS: bin/hbase passes bash -n PASS: bin/hbase-config.sh passes bash -n PASS: conf/hbase-env.sh passes bash -n PASS: Java executable is usable PASS: HBase launcher can execute version SKIP: ShellCheck not requested; set RUN_SHELLCHECK=1 to enable ==== Help output ==== PASS: bin/hbase --help succeeds PASS: help lists script.jsh PASS: help lists Script.java ==== Create test scripts ==== PASS: test scripts created ==== JShell script dispatch ==== PASS: .jsh dispatch succeeds with quoted arguments PASS: .jsh preserves spaces, empty arguments, and literal glob characters PASS: .jsh dispatch succeeds with no arguments PASS: .jsh reports zero positional arguments ==== JShell System.exit propagation ==== PASS: System.exit status propagates from .jsh ==== JShell feedback options ==== PASS: .jsh accepts HBASE_JSHELL_ARGS='--feedback verbose' PASS: no duplicate JShell feedback option for '--feedback verbose' PASS: script runs with feedback option '--feedback verbose' PASS: .jsh accepts HBASE_JSHELL_ARGS='--feedback=verbose' PASS: no duplicate JShell feedback option for '--feedback=verbose' PASS: script runs with feedback option '--feedback=verbose' PASS: .jsh accepts HBASE_JSHELL_ARGS='-s' PASS: no duplicate JShell feedback option for '-s' PASS: script runs with feedback option '-s' PASS: .jsh accepts HBASE_JSHELL_ARGS='-v' PASS: no duplicate JShell feedback option for '-v' PASS: script runs with feedback option '-v' ==== JShell execution options ==== PASS: .jsh accepts HBASE_JSHELL_ARGS='--execution local' PASS: script runs with execution option '--execution local' PASS: .jsh accepts HBASE_JSHELL_ARGS='--execution=local' PASS: script runs with execution option '--execution=local' PASS: debug execution-option invocation succeeds PASS: debug execution-option invocation runs the script ==== Java single-file dispatch ==== PASS: .java dispatch succeeds with quoted arguments PASS: .java preserves spaces, empty arguments, and literal glob characters PASS: .java dispatch handles a path containing spaces PASS: .java path-with-spaces invocation reaches main ==== Missing-script diagnostics ==== PASS: missing .jsh fails PASS: missing .java fails PASS: missing .jsh has a useful diagnostic PASS: missing .java has a useful diagnostic ==== JShell stdin handling ==== PASS: .jsh terminates with stdin redirected PASS: .jsh completes without remaining interactive input ==== Interactive JShell regression ==== PASS: interactive jshell starts and exits PASS: interactive jshell evaluates code ==== Custom JShell startup file ==== PASS: custom JShell startup file is loaded PASS: custom startup marker is visible to the script ==== Known HBASE_JSHELL_ARGS whitespace behavior ==== SKIP: HBASE_JSHELL_ARGS values containing spaces are not supported by current parsing ==== HBASE_NOEXEC path ==== PASS: HBASE_NOEXEC .java path succeeds PASS: HBASE_NOEXEC preserves .java arguments PASS: HBASE_NOEXEC .jsh path succeeds PASS: HBASE_NOEXEC preserves .jsh execution ==== Optional Maven validation ==== SKIP: Maven validation not requested; set RUN_MAVEN=1 to enable ==== Summary ==== Repository: /workspaces/hbase Test files: /tmp/hbase-8703-validation.Ze2TV2 Passed: 51 Skipped: 3 Failed: 0 Validation completed successfully. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
