ankitsol commented on code in PR #7617:
URL: https://github.com/apache/hbase/pull/7617#discussion_r2994846425
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##########
@@ -106,9 +117,25 @@ public final void run() {
continue;
}
try {
- WALEntryBatch entryBatch = entryReader.poll(getEntriesTimeout);
+ // check time-based offset persistence
+ if (shouldPersistLogPosition()) {
+ // Trigger offset persistence via existing retry/backoff mechanism
in shipEdits()
+ WALEntryBatch emptyBatch = createEmptyBatchForTimeBasedFlush();
+ if (emptyBatch != null) shipEdits(emptyBatch);
Review Comment:
I was thinking to add tests to the final PR against our continuous backup
feature branch once I get approval on code implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
