ankitsol commented on code in PR #7617:
URL: https://github.com/apache/hbase/pull/7617#discussion_r2994831828
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##########
@@ -215,6 +255,13 @@ private void shipEdits(WALEntryBatch entryBatch) {
entryBatch.getNbOperations(), (endTimeNs - startTimeNs) / 1000000);
}
break;
+ } catch (IOException ioe) {
+ // Offset-Persist failure is treated as fatal to this worker since it
might come from
Review Comment:
> Better introduce a abortAndRestart method in ReplicationSourceShipper to
call a method in ReplicationSource to replace the current shipper with a new
one. This can avoid introducing a new monitor thread. And also, we can deal
with InterruptedException with the same way, as usually if we want to shutdown,
we will first change a running or close flag and then interrupt, so when we
want to reschedule, we can check the flag to determine whether we should quit
now.
@Apache9 @anmolnar @taklwu I have implemented this approach, please help me
with review these code changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
