hgromer commented on code in PR #7288:
URL: https://github.com/apache/hbase/pull/7288#discussion_r2334556935
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##########
@@ -2651,4 +2651,7 @@ List<LogEntry> getLogEntries(Set<ServerName> serverNames,
String logType, Server
* Get the list of cached files
*/
List<String> getCachedFilesList(ServerName serverName) throws IOException;
+
+ @InterfaceAudience.Private
+ void restoreBackupSystemTable(String snapshotName) throws IOException;
Review Comment:
execProcedure only works for distributed procedures, which require
cluster-wide coordination, so I didn't think that it applied to this case, plus
it makes the table locking stuff more difficult.
> You could also add an PRC to MasterService that you could call from
BackupSystemTable
Isn't that what the Admin is doing in this case? It's connecting to the
MasterRpcServices. Otherwise, I need to create an entirely new type of
connection wrapper class in order to interface with the MasterRPCServices. I'm
happy to do that if you think that's a better approach.
Let me know if I'm misunderstanding something though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
