ndimiduk commented on code in PR #7288:
URL: https://github.com/apache/hbase/pull/7288#discussion_r2362796533
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##########
@@ -2651,4 +2651,7 @@ List<LogEntry> getLogEntries(Set<ServerName> serverNames,
String logType, Server
* Get the list of cached files
*/
List<String> getCachedFilesList(ServerName serverName) throws IOException;
+
+ @InterfaceAudience.Private
+ void restoreBackupSystemTable(String snapshotName) throws IOException;
Review Comment:
I dislike them both equally. Well, at least the whole `Hbck` private API is
hidden behind the one method call on the public object. Consider how much worse
things would be if all of Hbck API sat directly on Admin.
Ideally we one day ship an interface that is only our public api, no
qualifiers. It's unambiguous and there's no nuance to consumers as to what we
consider private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
