[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154786#comment-16154786
]
stack commented on HBASE-17980:
-------------------------------
Patch looks great.
I was going to suggest moving RegionInfo to hbase-common but it looks like it
is pretty-well contained by hbase-client module so ignore this remark.
So a mutable and an immutable? RegionInfoBuilder.MutableRegionInfo; ? Do we
have to have a MutableRI? Seems a bit odd having a Builder to make a mutable
type? It looks like this is only transitional going by comments in code?
Can this return a RI instead of a MRI:
public static MutableRegionInfo getRegionInfoForReplica
Does the Admin Interface API change? I don't see it in this patch.
Nice work
> Any HRegionInfo we give out should be immutable
> -----------------------------------------------
>
> Key: HBASE-17980
> URL: https://issues.apache.org/jira/browse/HBASE-17980
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Chia-Ping Tsai
> Assignee: Kuan-Po Tseng
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch
>
>
> This is similar to HBASE-15583.
> # Introduce RegionInfo class. HRegionInfo will extend RegionInfo.
> # Deprecate HRegionInfo to be removed in 3.0
> # RegionInfo contain all of the read-only methods of HRegionInfo
> # Add "RegionInfo Builder"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
