[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152829#comment-16152829
]
Chia-Ping Tsai commented on HBASE-17980:
----------------------------------------
*fix:00*
{code}
+
+public class RegionInfoBuilder {
{code}
Add IA.Private to RegionInfoBuilder
*fix:01*
{code}
+ static final Comparator<RegionInfo> COMPARATOR
{code}
remove the redundant modifier.
*fix:02*
Just deprecate the stale helper methods without coping the impl to
MutableRegionInfo. For example:
# HRegionInfo#getRegionNameAsStringForDisplay
# HRegionInfo#getRegionNameForDisplay
# HRegionInfo#toDelimitedByteArray
I've only skimmed the HRegionInfo. Please double check it. Also, the conversion
(pb <-> our object) methods can be moved to ProtobufUtil.
*fix:03*
Consider adding the tests for RegionInfo built by RegionInfoBuilder. You can
copy the tests from TestHRegionInfo, and replace the HRegionInfo by RegionInfo.
> Any HRegionInfo we give out should be immutable
> -----------------------------------------------
>
> Key: HBASE-17980
> URL: https://issues.apache.org/jira/browse/HBASE-17980
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Chia-Ping Tsai
> Assignee: Kuan-Po Tseng
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch
>
>
> This is similar to HBASE-15583.
> # Introduce RegionInfo class. HRegionInfo will extend RegionInfo.
> # Deprecate HRegionInfo to be removed in 3.0
> # RegionInfo contain all of the read-only methods of HRegionInfo
> # Add "RegionInfo Builder"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
