[
https://issues.apache.org/jira/browse/HBASE-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246589#comment-15246589
]
Enis Soztutar commented on HBASE-15631:
---------------------------------------
The branch-1 patch does not contain the dependencies in the master patch:
{code}
+ <!-- General dependencies -->
{code}
is there a reason? I guess they are not used, but it is important to keep these
in sync. Should we do a follow up to the master patch?
bq. Forgot to mention I had to add a small change to LocalHBaseCluster
I can see why this is needed. The hbase-rsgroups module is running without the
hbase-site.xml from the hbase-server/src/test/resources. Thus, the ports are
not configured to be -1. Adding this will solve this issue:
{code}
+ <build>
> +
<testResources>
> +
<testResource>
> + <!--
We depend on hbase-server test resources -->
> +
<directory>../hbase-server/src/test/resources</direc
> +
<excludes>
> +
<exclude>META-INF/NOTICE</exclude>
> +
<exclude>META-INF/LICENSE</exclude>
> +
</excludes>
> +
</testResource>
> +
</testResources>
{code}
in {{hbase-rsgroup/pom.xml}}.
The change in LocalHBaseCluster.java is good, but we have to do this in master
as well.
AssignmentManager.java does not contain the following change:
{code}
> if
(newPlan) {
> -
ServerName destination = balancer.randomAssignment(reg
> +
ServerName destination = null;
> + try {
> +
destination = balancer.randomAssignment(region, dest
> + } catch
(IOException ex) {
> +
LOG.warn("Failed to create new plan.",ex);
> + return
null;
> + }
{code}
in hbase-shell/src/main/ruby/shell/commands/get_rsgroup.rb
this is different between the master patch and branch-1 patch:
{code}
+ rsgroup_admin.get_rsgroup(group_name) do |s| | +
group_admin.get_rsgroup(group_name) do |s|
{code}
Something to fix in master or both forms work?
> Backport Regionserver Groups (HBASE-6721) to branch-1
> ------------------------------------------------------
>
> Key: HBASE-15631
> URL: https://issues.apache.org/jira/browse/HBASE-15631
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 1.4.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Attachments: HBASE-15631.patch, HBASE-15631_1_branch-1.patch
>
>
> Based on dev list discussion backporting region server group should not be an
> issue as it does not: 1. destabilize the code. 2. cause backward
> incompatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
