Prajwal-banakar opened a new pull request, #371:
URL: https://github.com/apache/fluss-rust/pull/371
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss-rust/issues). Exceptions are made for
typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #321
<!-- What is the purpose of the change -->
The purpose of this change is to make the client-side writer batch timeout
configurable. Previously, this was hardcoded to 500ms, which differed from the
Java client's default of 100ms and prevented users from tuning the
latency/throughput trade-off.
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
- Config Enhancement: Added writer_batch_timeout_ms to the Config struct in
config.rs with a default value of 100ms to match the Java implementation.
- Accumulator Update: Updated RecordAccumulator in accumulator.rs to
initialize using the configuration value instead of the hardcoded 500.
- C++ Binding Compatibility: Updated the C++ FFI bridge in
bindings/cpp/src/lib.rs to include the new configuration field, ensuring the
workspace continues to compile.
### Tests
<!-- List UT and IT cases to verify this change -->
- Unit Tests: Ran cargo test --workspace. All 182 unit tests passed,
including existing accumulator tests.
- Integration Tests: Ran cargo test --features integration_tests
--workspace. Verified that core logic remains sound despite local environment
port contention in Docker.
- Manual Verification: Used git diff to confirm the total removal of the
hardcoded 500ms value.
### API and Format
<!-- Does this change affect API or storage format -->
This change adds a new configuration option writer_batch_timeout_ms to the
client Config. It does not affect the storage format or existing public method
signatures.
### Documentation
<!-- Does this change introduce a new feature -->
This change introduces a new configuration parameter for the Rust client.
The field is documented within the code using doc comments that align with the
Apache Fluss Java documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
