swuferhong opened a new pull request, #2710:
URL: https://github.com/apache/fluss/pull/2710
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #1018
<!-- What is the purpose of the change -->
When MetadataManager.createTable() creates a table node empty (via
creatingParentsIfNeeded) and immediately calls setData with real data,
CuratorCache's internal async getData() for the NodeCreated event may
read the post-setData state. This causes NODE_CREATED to carry full
data (version>0) while the subsequent NODE_CHANGED is suppressed
(same version already cached), resulting
in a lost CreateTableEvent.
Previously, processCreateTable was only called in the NODE_CHANGED
branch. This fix adds table path handling in the NODE_CREATED branch:
when NODE_CREATED fires with non-empty table data, processCreateTable
is called as a fallback, ensuring CreateTableEvent is always produced
regardless of whether NODE_CHANGED fires.
This also fixes the case where CuratorCache initial sync reports
existing table nodes as NODE_CREATED with full data.
- Add table path + non-empty data check in NODE_CREATED branch
- Add CuratorCacheRaceConditionTest to prove the race condition exists
- Add testTableCreationDetectedViaNodeCreatedEvent to verify the fix
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
