Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r110379666
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -135,8 +135,11 @@ abstract class TableFunction[T] extends
UserDefinedFunction {
*
* @param arguments arguments of a function call (only literal arguments
* are passed, nulls for non-literal ones)
+ * @param typeInfos The type information of the parameters. only valid
argument types
+ * are passed, nulls for non-valid ones.
* @return [[TypeInformation]] of result type or null if Flink should
determine the type
*/
- def getResultType(arguments: java.util.List[AnyRef]): TypeInformation[T]
= null
+ def getResultType(arguments: java.util.List[AnyRef],
+ typeInfos: java.util.List[TypeInformation[_]]):
TypeInformation[T] = null
--- End diff --
I was thinking about this again. Maybe we should pass a `List[Class[_]]`
rather than `List[TypeInformation[_]]`. The `eval` method receives regular
classes (or primitives) and does not have to deal with type informations.
What do you think, @clarkyzl and @KurtYoung?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
