Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3721#discussion_r111994207
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ---
    @@ -376,6 +392,169 @@ private static NetworkEnvironment 
createNetworkEnvironment(
        }
     
        /**
    +    * Calculates the amount of memory used for network buffers based on 
the total memory to use and
    +    * the according configuration parameters.
    +    *
    +    * The following configuration parameters are involved:
    +    * <ul>
    +    *  <li>{@link TaskManagerOptions#NETWORK_BUFFERS_MEMORY_FRACTION},</li>
    +    *      <li>{@link TaskManagerOptions#NETWORK_BUFFERS_MEMORY_MIN},</li>
    +    *      <li>{@link TaskManagerOptions#NETWORK_BUFFERS_MEMORY_MAX}, 
and</li>
    +    *  <li>{@link TaskManagerOptions#NETWORK_NUM_BUFFERS} (fallback if the 
ones above do not exist)</li>
    +    * </ul>.
    +    *
    +    * @param totalJavaMemorySize
    +    *              overall available memory to use (heap and off-heap, in 
bytes)
    +    * @param config
    +    *              configuration object
    +    *
    +    * @return memory to use for network buffers (in bytes)
    +    */
    +   public static long calculateNetworkBuf(long totalJavaMemorySize, 
Configuration config) {
    --- End diff --
    
    how about a slightly longer method name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to