Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3721#discussion_r111983754
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ---
    @@ -410,24 +410,47 @@ private static NetworkEnvironment 
createNetworkEnvironment(
         *
         * @return memory to use for network buffers (in bytes)
         */
    +   @SuppressWarnings("deprecation")
        public static long calculateNetworkBuf(long totalJavaMemorySize, 
Configuration config) {
    +           assert totalJavaMemorySize > 0;
    --- End diff --
    
    use Preconditions instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to