Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3594#discussion_r109395373
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/cost/FlinkRelMdRowCount.scala
---
@@ -23,13 +23,17 @@ import org.apache.calcite.util.BuiltInMethod
import org.apache.flink.table.plan.nodes.dataset.{DataSetCalc, DataSetSort}
import java.lang.Double
+import org.apache.flink.table.rel.logical.FlinkLogicalCalc
+
object FlinkRelMdRowCount extends RelMdRowCount {
- val SOURCE: RelMetadataProvider =
ReflectiveRelMetadataProvider.reflectiveSource(
- BuiltInMethod.ROW_COUNT.method,
- this)
+ val SOURCE: RelMetadataProvider =
ReflectiveRelMetadataProvider.reflectiveSource(
+ BuiltInMethod.ROW_COUNT.method,
+ this)
+
+ def getRowCount(rel: FlinkLogicalCalc, mq: RelMetadataQuery): Double =
rel.estimateRowCount(mq)
--- End diff --
Can we change this to `def getRowCount(rel: Calc, mq: RelMetadataQuery):
Double` to cover `DataSetCalc` and `FlinkLogicalCalc` or would that be too
generic?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
