[ 
https://issues.apache.org/jira/browse/FLINK-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948781#comment-15948781
 ] 

ASF GitHub Bot commented on FLINK-5625:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3651#discussion_r108885047
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
 ---
    @@ -59,6 +59,9 @@ public SentinelSequenceNumber toSentinelSequenceNumber() {
        /** The initial timestamp to start reading Kinesis stream from (when 
AT_TIMESTAMP is set for STREAM_INITIAL_POSITION */
        public static final String STREAM_INITIAL_TIMESTAMP = 
"flink.stream.initpos.timestamp";
     
    +   /** The date format of initial timestamp to start reading Kinesis 
stream from (when AT_TIMESTAMP is set for STREAM_INITIAL_POSITION */
    --- End diff --
    
    Ah the other comments for the keys actually all miss a ")" at the end :) 
Could you fix those?


> Let Date format for timestamp-based start position in Kinesis consumer be 
> configurable.
> ---------------------------------------------------------------------------------------
>
>                 Key: FLINK-5625
>                 URL: https://issues.apache.org/jira/browse/FLINK-5625
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kinesis Connector
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Wei-Che Wei
>
> Currently, the Kinesis consumer's Date format for timestamp-based start 
> positions is fixed. It'll be nice to make this format configurable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to