[
https://issues.apache.org/jira/browse/FLINK-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948605#comment-15948605
]
ASF GitHub Bot commented on FLINK-5625:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3651#discussion_r108862488
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -224,27 +222,19 @@ private static void
validateOptionalPositiveDoubleProperty(Properties config, St
}
}
- private static void validateOptionalDateProperty(Properties config,
String timestampKey, String formatKey, String message) {
+ private static void validateOptionalDateProperty(Properties config,
String timestampKey, String format, String message) {
if (config.containsKey(timestampKey)) {
- if (config.containsKey(formatKey)) {
- try {
- SimpleDateFormat customDateFormat = new
SimpleDateFormat(config.getProperty(formatKey));
-
customDateFormat.parse(config.getProperty(timestampKey));
- } catch (ParseException |
IllegalArgumentException | NullPointerException exception) {
- throw new
IllegalArgumentException(message);
- }
- } else {
+ try {
+ SimpleDateFormat customDateFormat = new
SimpleDateFormat(format);
+
customDateFormat.parse(config.getProperty(timestampKey));
+ } catch (ParseException | IllegalArgumentException |
NullPointerException exception) {
try {
-
initTimestampDateFormat.parse(config.getProperty(timestampKey));
- } catch (ParseException exception) {
- try {
- double value =
Double.parseDouble(config.getProperty(timestampKey));
- if (value < 0) {
- throw new
NumberFormatException();
- }
- } catch (NumberFormatException
numberFormatException) {
- throw new
IllegalArgumentException(message);
+ double value =
Double.parseDouble(config.getProperty(timestampKey));
+ if (value < 0) {
+ throw new
NumberFormatException();
--- End diff --
Shouldn't we actually throw `new IllegalArgumentException(message)` here?
> Let Date format for timestamp-based start position in Kinesis consumer be
> configurable.
> ---------------------------------------------------------------------------------------
>
> Key: FLINK-5625
> URL: https://issues.apache.org/jira/browse/FLINK-5625
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
>
> Currently, the Kinesis consumer's Date format for timestamp-based start
> positions is fixed. It'll be nice to make this format configurable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
