Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3629#discussion_r108450477
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -91,21 +91,22 @@ object AggregateUtil {
}
/**
- * Create an
[[org.apache.flink.streaming.api.functions.ProcessFunction]] for ROWS clause
+ * Create an
[[org.apache.flink.streaming.api.functions.ProcessFunction]] for
* bounded OVER window to evaluate final aggregate value.
*
* @param namedAggregates List of calls to aggregate functions and
their output field names
* @param inputType Input row type
- * @param inputFields All input fields
* @param precedingOffset the preceding offset
+ * @param isRangeClause It is a tag that indicates whether the OVER
clause is rangeClause
* @param isRowTimeType It is a tag that indicates whether the time
type is rowTimeType
* @return [[org.apache.flink.streaming.api.functions.ProcessFunction]]
*/
- private[flink] def createRowsClauseBoundedOverProcessFunction(
+ private[flink] def createBoundedOverProcessFunction(
namedAggregates: Seq[CalcitePair[AggregateCall, String]],
inputType: RelDataType,
precedingOffset: Long,
- isRowTimeType: Boolean): ProcessFunction[Row, Row] = {
+ isRangeClause: Boolean = false,
--- End diff --
I don't think we should default values here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
