Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3629#discussion_r108470691
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
 ---
    @@ -411,6 +411,128 @@ class SqlITCase extends StreamingWithStateTestBase {
         assertEquals(expected.sorted, StreamITCase.testResults.sorted)
       }
     
    +  @Test
    +  def testBoundPartitionedEventTimeWindowWithRange(): Unit = {
    +    val data = Seq(
    --- End diff --
    
    I think a bit more diverse test data would be good to cover more corner 
cases. 
    Basically check that each loop is correctly triggered (retract data of two 
(or more timestamps), emit different rows in one timestamp, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to