Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3531#discussion_r107409859
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupsStateHandle.java
 ---
    @@ -91,10 +98,10 @@ public KeyGroupsStateHandle 
getKeyGroupIntersection(KeyGroupRange keyGroupRange)
     
        /**
         *
    -    * @return the internal key-group range to offsets metadata
    +    * @return the start key group in the key-group range of this handle
         */
    -   public KeyGroupRangeOffsets getGroupRangeOffsets() {
    -           return groupRangeOffsets;
    +   public int getStartKeyGroup() {
    --- End diff --
    
    I suggest to remove this pass-through method, as it at a very low 
abstraction level. This information can be obtained already from the result of 
`getKeyGroupRange()`. Now, that we expose the `KeyGroupRange`, also 
`getNumberOfKeyGroups()` could be removed, as we can ask the `KeyGroupRange` 
directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to