[
https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932905#comment-15932905
]
ASF GitHub Bot commented on FLINK-5413:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106939552
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/TableEnvironmentTest.java
---
@@ -47,10 +48,16 @@
import org.junit.runners.Parameterized;
@RunWith(Parameterized.class)
-public class TableEnvironmentITCase extends
TableProgramsCollectionTestBase {
+public class TableEnvironmentTest {
- public TableEnvironmentITCase(TableConfigMode configMode) {
- super(configMode);
+ private TableConfig config;
+ private BatchTableTestUtil util = new BatchTableTestUtil();
+
+ public TableEnvironmentTest(TableProgramsTestBase.TableConfigMode
configMode) {
--- End diff --
This is not a TableProgramsTestBase anymore so we can get rid of this
constructor and the parameters and simplify the class.
> Convert TableEnvironmentITCases to unit tests
> ---------------------------------------------
>
> Key: FLINK-5413
> URL: https://issues.apache.org/jira/browse/FLINK-5413
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: GaoLun
>
> The following IT cases could be converted into unit tests:
> - {{org.apache.flink.table.api.scala.batch.TableEnvironmentITCase}}
> - {{org.apache.flink.table.api.java.batch.TableEnvironmentITCase}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
