[
https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932902#comment-15932902
]
ASF GitHub Bot commented on FLINK-5413:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106935333
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/TableEnvironmentTest.java
---
@@ -209,28 +206,20 @@ public void testRegisterTableFromOtherEnv() throws
Exception {
@Test
public void testAsFromTuple() throws Exception {
--- End diff --
I think we still need the from tuple, from pojo, and toTuple, toPojo etc.
tests. There are no other tests that test if the input and output conversion
works correctly. Can you create `DataSetScanITCase` in
`org.apache.flink.table.runtime.dataset`? The overall goal is to reduce ITCases
such that we only test the "runtime" classes `DataSetXXX` and `DataStreamXXX`.
> Convert TableEnvironmentITCases to unit tests
> ---------------------------------------------
>
> Key: FLINK-5413
> URL: https://issues.apache.org/jira/browse/FLINK-5413
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: GaoLun
>
> The following IT cases could be converted into unit tests:
> - {{org.apache.flink.table.api.scala.batch.TableEnvironmentITCase}}
> - {{org.apache.flink.table.api.java.batch.TableEnvironmentITCase}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
