Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3565#discussion_r106939552
  
    --- Diff: 
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/TableEnvironmentTest.java
 ---
    @@ -47,10 +48,16 @@
     import org.junit.runners.Parameterized;
     
     @RunWith(Parameterized.class)
    -public class TableEnvironmentITCase extends 
TableProgramsCollectionTestBase {
    +public class TableEnvironmentTest {
     
    -   public TableEnvironmentITCase(TableConfigMode configMode) {
    -           super(configMode);
    +   private TableConfig config;
    +   private BatchTableTestUtil util = new BatchTableTestUtil();
    +
    +   public TableEnvironmentTest(TableProgramsTestBase.TableConfigMode 
configMode) {
    --- End diff --
    
    This is not a TableProgramsTestBase anymore so we can get rid of this 
constructor and the parameters and simplify the class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to