Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106935333
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/batch/TableEnvironmentTest.java
---
@@ -209,28 +206,20 @@ public void testRegisterTableFromOtherEnv() throws
Exception {
@Test
public void testAsFromTuple() throws Exception {
--- End diff --
I think we still need the from tuple, from pojo, and toTuple, toPojo etc.
tests. There are no other tests that test if the input and output conversion
works correctly. Can you create `DataSetScanITCase` in
`org.apache.flink.table.runtime.dataset`? The overall goal is to reduce ITCases
such that we only test the "runtime" classes `DataSetXXX` and `DataStreamXXX`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
