Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3501#discussion_r105239060
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java
 ---
    @@ -906,6 +919,256 @@ public void testChannelSelectors() {
        }
     
        /////////////////////////////////////////////////////////////
    +   // KeyBy testing
    +   /////////////////////////////////////////////////////////////
    +
    +   @Rule
    +   public ExpectedException expectedException = ExpectedException.none();
    --- End diff --
    
    First time I'm seeing this pattern and i can't help but feel that a simple 
try-catch block would be more readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to