Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3336#discussion_r102033285
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -834,7 +836,7 @@ private void restoreKVStateData() throws IOException,
RocksDBException {
}
@Override
- protected <N, T> InternalValueState<N, T> createValueState(
+ public <N, T> InternalValueState<N, T> createValueState(
--- End diff --
I think these should stay `private`/`protected`. It was mistake to make
them `public` in the other state backends. Creating a state can always be
achieved with `getPartitionedState()` and a `StateDescriptor`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
