[
https://issues.apache.org/jira/browse/FLINK-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870221#comment-15870221
]
ASF GitHub Bot commented on FLINK-5799:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3311
Thanks for the review @StephanEwen.
You mean something like the `Executor` interface with the additional
methods for the scheduled execution. Differently said, removing the `Service`
methods like `shutdown`, `shutdownNow` and `awaitTermination` from the
interface?
That is a good idea. If we should stumble across the problem that a
component needs an actual `ScheduledExecutorService` implementation, then we
can still have a wrapper which throws an `UnsupportedOperationException` when
calling the respective methods. I will adapt the PR in that way.
> Let RpcService.scheduleRunnable return ScheduledFuture
> ------------------------------------------------------
>
> Key: FLINK-5799
> URL: https://issues.apache.org/jira/browse/FLINK-5799
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.3.0
>
>
> Currently, the method {{RpcService.scheduleRunnable}} does not return a
> control instance for the scheduled runnable. I think it would be good to
> return a {{ScheduledFuture}} with which one can cancel the scheduled runnable
> after it has been scheduled, e.g. a timeout registration which became
> obsolete. This API is also more in line with the {{ScheduledExecutorService}}
> where one also receives a {{ScheduledFuture}} after scheduling a runnable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
