[ https://issues.apache.org/jira/browse/FLINK-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867126#comment-15867126 ]
Zhijiang Wang commented on FLINK-5799: -------------------------------------- This fix is useful and the {{HeartbeatManagerSenderImpl}} can get benefit from it. After this is done, it is better for {{HeartbeatManagerSenderImpl}} to use the RpcService.scheduleRunnable to schedule heartbeat by interval time. > Let RpcService.scheduleRunnable return ScheduledFuture > ------------------------------------------------------ > > Key: FLINK-5799 > URL: https://issues.apache.org/jira/browse/FLINK-5799 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination > Affects Versions: 1.3.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Minor > Fix For: 1.3.0 > > > Currently, the method {{RpcService.scheduleRunnable}} does not return a > control instance for the scheduled runnable. I think it would be good to > return a {{ScheduledFuture}} with which one can cancel the scheduled runnable > after it has been scheduled, e.g. a timeout registration which became > obsolete. This API is also more in line with the {{ScheduledExecutorService}} > where one also receives a {{ScheduledFuture}} after scheduling a runnable. -- This message was sent by Atlassian JIRA (v6.3.15#6346)