Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3330#discussion_r101450405
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1463,21 +1465,23 @@ class CodeGenerator(
*/
def addReusableFunction(function: UserDefinedFunction): String = {
val classQualifier = function.getClass.getCanonicalName
- val fieldTerm = s"function_${classQualifier.replace('.', '$')}"
+ val functionSerializedData = serialize(function)
+ val fieldTerm =
+ s"""
+ |function_${classQualifier.replace('.',
'$')}_${DigestUtils.md5Hex(functionSerializedData)}
--- End diff --
It seems that if we register two identical function (not the same
reference), the field term will the same, which will compile error here. Such
as:
```
val func1 = new MyFunction
val func2 = new MyFunction
env.register("func1", func1)
env.register("func2", func2)
```
The func1 and func2 is two different object but the serialized bytes are
equals.
BTW, I will suggest to include this case into your new IT cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
