Github user barcahead commented on a diff in the pull request:
https://github.com/apache/flink/pull/3267#discussion_r100660350
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/services/MesosServicesUtils.java
---
@@ -40,9 +41,11 @@ public static MesosServices
createMesosServices(Configuration configuration) thr
return new StandaloneMesosServices();
case ZOOKEEPER:
- final String zkMesosRootPath =
configuration.getString(
+ final String zkMesosRootPath =
ConfigurationUtil.getStringWithDeprecatedKeys(
+ configuration,
ConfigConstants.HA_ZOOKEEPER_MESOS_WORKERS_PATH,
-
ConfigConstants.DEFAULT_ZOOKEEPER_MESOS_WORKERS_PATH);
+
ConfigConstants.DEFAULT_ZOOKEEPER_MESOS_WORKERS_PATH,
+
ConfigConstants.ZOOKEEPER_MESOS_WORKERS_PATH);
--- End diff --
Thanks for the review.
I looked into `HighAvailabilityOptions` and found that it doesn't contain
all the HA options, some options are still in `ConfigConstants`.
It looks like this part is still in the middle of refactoring, right? I
also heard some discussion from @greghogan about generating configuration
document from `ConfigOption` automatically.
Is there any work I can help with, like move options from `ConfigConstants`
to corresponding `xxConfigOptions` files or the automatic work? If it is the
right direction and there is some work I can do, I would say to have another PR
for the work, if not I would just move `HA_ZOOKEEPER_MESOS_WORKERS_PATH` to
`HighAvailabilityOptions` and finish this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
