Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3267#discussion_r100556946
  
    --- Diff: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/services/MesosServicesUtils.java
 ---
    @@ -40,9 +41,11 @@ public static MesosServices 
createMesosServices(Configuration configuration) thr
                                return new StandaloneMesosServices();
     
                        case ZOOKEEPER:
    -                           final String zkMesosRootPath = 
configuration.getString(
    +                           final String zkMesosRootPath = 
ConfigurationUtil.getStringWithDeprecatedKeys(
    +                                   configuration,
                                        
ConfigConstants.HA_ZOOKEEPER_MESOS_WORKERS_PATH,
    -                                   
ConfigConstants.DEFAULT_ZOOKEEPER_MESOS_WORKERS_PATH);
    +                                   
ConfigConstants.DEFAULT_ZOOKEEPER_MESOS_WORKERS_PATH,
    +                                   
ConfigConstants.ZOOKEEPER_MESOS_WORKERS_PATH);
    --- End diff --
    
    I think it's better if we replace this directly by a `ConfigOption`. There 
you can also define deprecated keys. This is the encouraged way to read 
configuration values. Take a look at `HighAvailabilityOptions` to see how it is 
used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to