CodeTrainerMan commented on issue #1218: URL: https://github.com/apache/flink-agents/issues/1218#issuecomment-6142216967
Thanks @joeyutong — that split works for me. #1224 will keep covering items 1, 2, 4, and 5, and item 3 is yours. One update on #1224 since this was filed: review also caught a related bug on the same failure path — a preparation-time failure (e.g. a `TaskLifecycleListener` throwing in `onActionPrepared`) surfaced as a `NullPointerException` from `Work.commit()` instead of the original exception, because `actionTask` was dereferenced before it was bound. The fix binds `actionTask` right after the poll and guards the `markInputRunFailed` call, so the input run is now marked failed even on a preparation failure (item 4's intent). It's covered by the new regression test `preparationFailureKeepsCauseAndMarksInputRunFailed`. Thanks @sangkyoonnam for reviewing, and glad the item-2 approaches line up — looking forward to basing item 3 on #1224. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
