CodeTrainerMan commented on issue #1218: URL: https://github.com/apache/flink-agents/issues/1218#issuecomment-6114334256
I'd like to take items 1, 2, 4 and 5 of this issue: - **1**: fix the thread contract documented on `TaskLifecycleListener` and `ComponentExecutionListener`, so they stop promising mailbox-thread callbacks that the parallel engine does not honor. - **2**: emit `onRecordStart` when the restore path requeues unfinished tasks, once per key, so the resumed round pairs with the `onRecordFinished` emitted on completion. - **4**: mark the input run failed before propagating an action failure from the parallel commit path, so `numOfInputRunsFailed` is counted and the active-run gauge and the terminal latency samples are released. - **5**: skip the synthetic no-op input action when restoring action metrics, matching the dequeue path, so the pending-action-task gauge returns to zero. Item 3 (rebinding subagent tasks on restore) touches the lock ordering in `ParallelExecutionLock`, so I would leave it to someone with more context on the parallel engine. I'll open a PR covering those four items. Happy to split it into separate PRs if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
