MartijnVisser commented on code in PR #29463: URL: https://github.com/apache/flink/pull/29463#discussion_r4256680493
########## flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTimestampITCase.java: ########## @@ -55,16 +56,18 @@ import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.TIMESTAMP_TIME_UNIT; import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.UTC_TIMEZONE; import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.WRITE_INT64_TIMESTAMP; -import static org.junit.Assert.assertEquals; +import static org.assertj.core.api.Assertions.assertThat; /** Test int64 timestamp. */ @ExtendWith(ParameterizedTestExtension.class) Review Comment: Good point. I'll open a separate ticket to bump to 5.14 (6.x needs Java 17) and keep this PR on ParameterizedTestExtension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
