MartijnVisser opened a new pull request, #29463:
URL: https://github.com/apache/flink/pull/29463
## What is the purpose of the change
`ParquetTimestampITCase` never ran its parameterized cases. Its tests are
plain `@Test` methods inherited from `FsStreamingSinkITCaseBase`, so
`ParameterizedTestExtension` does not apply and each test runs once with
`useInt64` false.
## Brief change log
- Use AssertJ in `check()` (hotfix commit)
- Override the four inherited tests as `@TestTemplate` and give the
parameter fields their own indices
## Verifying this change
`./mvnw -pl flink-formats/flink-parquet test -Dtest=ParquetTimestampITCase`
reports `Tests run: 4` on master and `Tests run: 28` with this change. Breaking
`ParquetRowDataWriter` locally (micros written as millis, or `utc-timezone =
false` ignored) passes on master and fails here. The timezone case only fails
when the JVM zone is not UTC (I used Europe/Amsterdam); I haven't checked which
zone CI uses. The class goes from about 10s to about 25s locally.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
