[
https://issues.apache.org/jira/browse/FLINK-39237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126369#comment-18126369
]
ChenZhuo commented on FLINK-39237:
----------------------------------
Hi Yu Tang and maintainers, I would be happy to help follow up on this issue if
the original author is no longer working on it. PR #27751 already proposes
TrainingExercisesBranch = master for both training shortcodes; it was closed by
the inactivity bot without merging. I would like to build on that work with
appropriate credit, subject to your agreement.
The current shortcodes still use the Flink Branch parameter. flink-training has
master and older 1.x release branches, but no release-2.2 branch. The proposed
scope is the same three files: add the independent training branch parameter
and use it in training_link and training_repo. I would verify the English and
Chinese rendered links with a release-2.2 docs branch setting and build the
docs following docs/README.md.
Would this approach and a follow-up contribution be welcome? If so, could a
committer assign this issue to me (chenzhuo)? I will wait for confirmation and
assignment before implementing.
> Docs training links should not depend on the Flink release branch
> -----------------------------------------------------------------
>
> Key: FLINK-39237
> URL: https://issues.apache.org/jira/browse/FLINK-39237
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
> Reporter: Yu Tang
> Priority: Major
> Labels: pull-request-available
>
> In the Flink docs site, training exercise links are generated through the
> {{training_link}} shortcode.
> At the moment, this shortcode uses the shared {{Branch}} value from
> {{docs/config.toml}}. When a new Flink release branch is created, {{Branch}}
> is updated to values such as {{release-2.2}}. However, the
> {{apache/flink-training}} repository does not create matching release
> branches. As a result, training links in docs pages such as
> {{docs/content/docs/learn-flink/event_driven.md}} point to non-existent
> GitHub paths and return 404 pages.
> This creates broken documentation links on release branches.
> *Proposed improvement*
> Introduce a dedicated config value for the training repository branch,
> separate from the main Flink docs branch, and update the training shortcodes
> to use that value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
