wenjin272 commented on code in PR #1185:
URL: https://github.com/apache/flink-agents/pull/1185#discussion_r4237046771
##########
python/flink_agents/plan/actions/tool_call_action.py:
##########
@@ -403,15 +398,15 @@ def _record_tool_response(
success: dict,
error: dict,
) -> None:
- response = value if isinstance(value, ToolResponse) else
ToolResponse.success(value)
+ response = to_tool_response(value)
Review Comment:
Thanks for catching this. Conversion errors are now handled per call, and
the failed outcome is passed to execution reporting so it agrees with
`ToolResponseEvent`. Other calls in the batch keep their results. Regression
tests cover a failing result in each batch position across sync, serial-async
and parallel execution.
We also relaxed ordinary return conversion in Java and Python: try JSON
first, then fall back to the string representation. A `date` now succeeds; the
failure-isolation test uses an object whose string conversion also raises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
