snuyanzin commented on code in PR #29026:
URL: https://github.com/apache/flink/pull/29026#discussion_r4192413687
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantInternalBuilder.java:
##########
@@ -448,10 +476,8 @@ public void appendUuid(UUID uuid) {
// modified.
// In either case, return the id of the key.
public int addKey(String key) {
- int id;
- if (dictionary.containsKey(key)) {
- id = dictionary.get(key);
- } else {
+ Integer id = dictionary.get(key);
+ if (id == null) {
Review Comment:
this silently changes the logic
because this code does not differentiate between no key and key with `null`
value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
