snuyanzin commented on code in PR #29026:
URL: https://github.com/apache/flink/pull/29026#discussion_r4192395675
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantInternalBuilder.java:
##########
@@ -139,9 +139,14 @@ public static BinaryVariant parseJson(byte[] bytes,
boolean allowDuplicateKeys)
}
/**
- * Similar {@link #parseJson(String, boolean)}, but takes a JSON parser
instead of string input.
+ * Parse the JSON value at the current token of a parser as a Variant
value. The parser must be
+ * positioned on the first token of the value. It is left on the last
token of the value, so a
+ * caller reading the value from a larger document continues with {@code
nextToken()}. The
+ * parser's own features apply, not the ones {@link #parseJson(String,
boolean)} uses.
+ *
+ * @throws IOException if any JSON parsing error happens.
*/
- private static BinaryVariant parseJson(JsonParser parser, boolean
allowDuplicateKeys)
+ public static BinaryVariant parseJson(JsonParser parser, boolean
allowDuplicateKeys)
Review Comment:
what is the reason for changing modifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
