raminqaf commented on code in PR #29369:
URL: https://github.com/apache/flink/pull/29369#discussion_r4184355140
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantInternalBuilder.java:
##########
@@ -537,7 +537,9 @@ public void finishWritingArray(int start,
ArrayList<Integer> offsets) {
// the
// input variant, we can directly copy the binary slice.
public void appendVariant(BinaryVariant v) {
- appendVariantImpl(v.getValue(), v.getMetadata(), v.getPos());
+ // A nested variant, such as a field or an element of another variant,
starts at its own
+ // position in the shared buffer. getValue() would copy it to position
0 instead.
+ appendVariantImpl(v.rawValue(), v.getMetadata(), v.getPos());
Review Comment:
Added new ticket and updated the commit:
https://issues.apache.org/jira/browse/FLINK-40911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
