raminqaf commented on code in PR #29369:
URL: https://github.com/apache/flink/pull/29369#discussion_r4184335761
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java:
##########
@@ -95,7 +96,7 @@ public CastExecutor<IN, OUT> create(
"public "
+ castExecutorClassName
+ "("
- + ctx.typeSerializers.values().stream()
+ + constructorFields.entrySet().stream()
.map(
entry ->
className(entry.getValue().getClass())
Review Comment:
Done. `declareReusableObject` now takes the declared type, and both contexts
use it for the field. The planner goes through `className(type)`, which fails
with a clear error for a type without a canonical name. It also takes a key
now, so casts of the same type share one converter instead of creating one per
call site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
