Shekharrajak commented on code in PR #28789:
URL: https://github.com/apache/flink/pull/28789#discussion_r4178254677
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/common/sql/ConnectionITCase.java:
##########
@@ -38,14 +46,34 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.entry;
-/** IT case for CREATE CONNECTION statement. */
-class CreateConnectionITCase extends BatchTestBase {
+/** IT cases for connection statements. */
+@ExtendWith(ParameterizedTestExtension.class)
+class ConnectionITCase {
- @Test
+ @Parameter public boolean isBatch;
+
+ @Parameters(name = "isBatch: {0}")
+ public static List<Boolean> parameters() {
+ return List.of(true, false);
+ }
Review Comment:
thought of having test for batch/streaming, following similar setup in other
test class like `SinkReuseITCase`. Seems like it is not useful in connection
case. Let me remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
