Shekharrajak commented on code in PR #28789:
URL: https://github.com/apache/flink/pull/28789#discussion_r4177989407
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/CreateConnectionITCase.java:
##########
@@ -73,6 +73,29 @@ void
testCreatePermanentConnectionRejectedWithoutSecretStore() {
.hasMessageContaining("WritableSecretStore must be
configured");
}
+ @Test
+ void testDropTemporaryConnection() {
+ tEnv().executeSql("CREATE TEMPORARY CONNECTION my_conn WITH ('k' =
'v')");
+
+ tEnv().executeSql("DROP TEMPORARY CONNECTION my_conn");
+
+
assertThat(catalogManager().getConnection(connectionIdentifier("my_conn"))).isEmpty();
+ }
+
+ @Test
+ void testDropTemporaryConnectionIfExists() {
+ tEnv().executeSql("DROP TEMPORARY CONNECTION IF EXISTS my_conn");
Review Comment:
updated
https://github.com/apache/flink/pull/28789/changes/6574825e0d515a4a07fc76763d692940fc9a8289
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/CreateConnectionITCase.java:
##########
@@ -73,6 +73,29 @@ void
testCreatePermanentConnectionRejectedWithoutSecretStore() {
.hasMessageContaining("WritableSecretStore must be
configured");
}
+ @Test
+ void testDropTemporaryConnection() {
+ tEnv().executeSql("CREATE TEMPORARY CONNECTION my_conn WITH ('k' =
'v')");
+
+ tEnv().executeSql("DROP TEMPORARY CONNECTION my_conn");
Review Comment:
Added
https://github.com/apache/flink/pull/28789/changes/6574825e0d515a4a07fc76763d692940fc9a8289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
