mateczagany commented on code in PR #1217:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1217#discussion_r4146536506
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/StatusRecorder.java:
##########
@@ -102,23 +104,7 @@ public void patchAndCacheStatus(CR resource,
KubernetesClient client) {
}
var prevStatus = convertPreviousStatus(resource, previousStatusNode);
-
- Exception err = null;
- for (int i = 0; i < 3; i++) {
- // We retry the status update 3 times to avoid some intermittent
connectivity errors
- try {
- replaceStatus(resource, prevStatus, client);
- err = null;
Review Comment:
I think it's nicer this way:
- no need for `err` variable
- no sleeping even after the third retry
- no misleading log `retrying 3/3...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
