snuyanzin commented on code in PR #29323:
URL: https://github.com/apache/flink/pull/29323#discussion_r4146102559
##########
flink-core/src/main/java/org/apache/flink/types/variant/VariantBuilder.java:
##########
@@ -58,7 +58,12 @@ public interface VariantBuilder {
/** Create a variant from a boolean. */
Variant of(boolean b);
- /** Create a variant from a BigDecimal. */
+ /**
+ * Create a variant from a BigDecimal. A negative scale is rescaled to 0,
which keeps the
+ * numeric value.
+ *
+ * @throws VariantTypeException if the precision or the scale of the
rescaled decimal exceeds 38
Review Comment:
is 38 same value as at `{@link BinaryVariantUtil#MAX_DECIMAL16_PRECISION}` ?
can we refer to this then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
