snuyanzin commented on code in PR #29323:
URL: https://github.com/apache/flink/pull/29323#discussion_r4146004268
##########
flink-core/src/test/java/org/apache/flink/types/variant/BinaryVariantInternalBuilderTest.java:
##########
@@ -143,6 +143,19 @@ void testParseJsonRejectsNonFiniteNumbers(final String
nonFiniteNumber) {
.isInstanceOf(IOException.class);
}
+ @ParameterizedTest
+ @ValueSource(
+ strings = {
+ "123456789012345678901234567890123456789",
+ "0.000000000000000000000000000000000000001"
+ })
+ void testParseJsonStoresNumbersOutsideDecimalRangeAsDouble(final String
number)
+ throws IOException {
+ BinaryVariant variant = BinaryVariantInternalBuilder.parseJson(number,
false);
+ assertThat(variant.getType()).isEqualTo(Variant.Type.DOUBLE);
Review Comment:
```suggestion
assertThat(variant.getType()).isSameAs(Variant.Type.DOUBLE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
