MartijnVisser commented on code in PR #28995:
URL: https://github.com/apache/flink/pull/28995#discussion_r4084348049
##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/utils/KubernetesUtilsTest.java:
##########
@@ -228,4 +231,26 @@ private void testCheckAndUpdatePortConfigOption(
assertThat(cfg.get(HighAvailabilityOptions.HA_JOB_MANAGER_PORT_RANGE))
.isEqualTo(expectedPort);
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"11.0.18", "11.0.18+10", "12.0.2", "15.0.1"})
Review Comment:
Added the ones `Runtime.Version.parse` accepts, plus `11.0.18.1+1` and
OpenJ9 `11.0.11+9` on the reject side. The Zing string doesn't parse, but the
check never parses: it reads `feature()` and `update()` from
`Runtime.version()`.
##########
pom.xml:
##########
@@ -671,6 +674,33 @@ under the License.
<artifactId>logging-interceptor</artifactId>
<version>${okhttp.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.jetbrains.kotlin</groupId>
+ <artifactId>kotlin-stdlib</artifactId>
+ <version>${kotlin.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jetbrains.kotlin</groupId>
+ <artifactId>kotlin-stdlib-common</artifactId>
+ <version>${kotlin.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jetbrains.kotlin</groupId>
+ <artifactId>kotlin-stdlib-jdk7</artifactId>
+ <version>${kotlin.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jetbrains.kotlin</groupId>
+ <artifactId>kotlin-stdlib-jdk8</artifactId>
+ <version>${kotlin.version}</version>
+ </dependency>
+ <dependency>
+ <!-- Converge the Kotlin stdlib's
org.jetbrains:annotations (13.0) with the newer version
+ pulled by other dependencies such as
testcontainers. -->
+ <groupId>org.jetbrains</groupId>
+ <artifactId>annotations</artifactId>
Review Comment:
No, the annotations are CLASS retention only. Replaced the pin with an
exclusion on the managed `kotlin-stdlib`; convergence still passes and
`flink-model-triton` no longer bundles it. `flink-model-openai` still bundles
13.0 through its own Kotlin `dependencyManagement`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
