snuyanzin commented on code in PR #28995:
URL: https://github.com/apache/flink/pull/28995#discussion_r4065695769
##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/utils/KubernetesUtilsTest.java:
##########
@@ -228,4 +231,26 @@ private void testCheckAndUpdatePortConfigOption(
assertThat(cfg.get(HighAvailabilityOptions.HA_JOB_MANAGER_PORT_RANGE))
.isEqualTo(expectedPort);
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"11.0.18", "11.0.18+10", "12.0.2", "15.0.1"})
Review Comment:
can we have tests for more weird jdk versions like
| `java.runtime.version` | Vendor | What's weird |
|---|---|---|
| `17.0.8.1+1` | IBM Semeru / Eclipse OpenJ9 | 4-part version (extra 4th
component) |
| `11.0.20.8.1` | Amazon Corretto | 5-part, dot-separated, **no `+build`** |
| `21.0.2+13-jvmci-23.1-b30` | GraalVM | extra `-jvmci-x.y` segment |
| `17.0.7+8-LTS-zing_23.05.0.0` | Azul Zing / Prime | vendor product version
embedded |
| `11.0.20+8-sapmachine` | SapMachine (SAP) | trailing vendor tag |
| `22+36-2370` | Oracle / OpenJDK | feature-only, no `.0.0` |
| `17-ea+1-LTS` | Oracle / OpenJDK (EA) | EA marker before `+build` |
| `11.0.11+9` | Eclipse OpenJ9 (Adoptium) | normal string, but
`java.vm.version = openj9-0.26.0` |
| `11.0.19+7-LTS` | Microsoft Build of OpenJDK | `-LTS` tag on build |
| `21-ea+35-2513` | Oracle / OpenJDK (EA) | EA + long build number |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
