snuyanzin commented on code in PR #222:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/222#discussion_r4057942184


##########
flink-connector-jdbc-core/pom.xml:
##########
@@ -149,7 +149,13 @@ under the License.
         <dependency>
             <groupId>org.apache.derby</groupId>
             <artifactId>derby</artifactId>
-            <version>10.17.1.0</version>
+            <version>10.16.1.1</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.derby</groupId>
+            <artifactId>derbytools</artifactId>
+            <version>10.16.1.1</version>

Review Comment:
   ok, thanks for clarification
   can you please
   1. extract version into property
   2. add a one line comment about jdk17/21 there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to