skrcode commented on code in PR #222:
URL:
https://github.com/apache/flink-connector-jdbc/pull/222#discussion_r4057936052
##########
flink-connector-jdbc-core/pom.xml:
##########
@@ -149,7 +149,13 @@ under the License.
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derby</artifactId>
- <version>10.17.1.0</version>
+ <version>10.16.1.1</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.derby</groupId>
+ <artifactId>derbytools</artifactId>
+ <version>10.16.1.1</version>
Review Comment:
Thanks for asking. The connector CI matrix runs on Java 17, but Apache lists
Derby 10.17.1.0 as requiring Java 21 or higher; 10.16.1.1 is the newest release
listed for Java 17 or higher
(https://db.apache.org/derby/derby_downloads.html). I also checked the jars:
10.17 classes use class-file version 63, whereas Java 17 supports up to 61.
Adding derbytools at 10.17 would resolve the missing org.apache.derby.jdbc
package seen in #204 test compilation, but the tests would still be unable to
run on Java 17. This PR therefore uses matching 10.16.1.1 derby and derbytools
artifacts. derbytools supplies EmbeddedXADataSource, which DerbyMetadata
imports, and both dependencies are test-scoped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
